fix(plugin-multi-tenant): tenant field unselectable in bulk upload "Edit all"#16466
Merged
Conversation
…dit all" (#16447) In a multi-tenant collection that has uploads enabled, picking the tenant field ("Site" in our test) inside the bulk-upload "Edit all" drawer leaves you with an unresponsive dropdown - clicks land on it but the menu never opens, so there's no way to bulk-assign a tenant to the files you're uploading. `TenantField` decides whether to render inline or wrap itself in `AssignTenantFieldModal` by checking if the `edit-${slug}` modal is open. The bulk-upload edit-many drawer uses `edit-${slug}-bulk-uploads` instead, so the check misses, the field re-wraps itself in a nested `AssignTenantFieldModal`. Widening the check to match both slugs makes the tenant relationship render inline in the bulk-edit drawer, the same way every other field does, and you can pick a tenant normally. ## Before [before-fix.webm](https://github.com/user-attachments/assets/ba7eda87-b849-4cd9-9a37-f76c84a0b124) ## After [after-fix.webm](https://github.com/user-attachments/assets/21e96f6c-ef3a-4330-8eef-f618d28a40d9) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1214434612753281
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
approved these changes
May 4, 2026
Member
|
🚀 This is included in version v3.85.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #16447