fix: use latest draft version data when trashing unpublished documents#15981
Merged
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
JarrodMFlesch
approved these changes
Mar 19, 2026
Contributor
|
🚀 This is included in version v3.80.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes document data being silently lost when bulk-trashing draft-only documents on collections with
trash: trueandversions.draftsenabled.Localized fields are the most visible symptom, but any field data that exists only in the versions table (i.e. never published) is affected.
Key Changes
updateoperation,queryDrafts(versions table) is now also used when fetching documents for a trash attempt, not only whenshouldSaveDraftis trueRoot Cause
Draft saves skip
updateOneon the main collection table (isSavingDraft === true), so the main table only reflects the last published state. When bulk-trashing, the operation was readingdocWithLocalesfrom the main table viafind()— picking up stale/empty data — and creating a new version from that stale snapshot.Single-document trash (
updateByID) was unaffected because it usesgetLatestCollectionVersion(), which always reads from the versions table.Fix
Fixes #15980