chore: migrate to TypeScript strict in Payload package (enable strictNullChecks) - #3#12586
Merged
Conversation
denolfe
previously approved these changes
May 30, 2025
denolfe
left a comment
Member
There was a problem hiding this comment.
I don't have any objections. Would like to get a few more eyes/approvals here for visibility, though.
DanRibbens
reviewed
Jun 2, 2025
DanRibbens
reviewed
Jun 2, 2025
DanRibbens
reviewed
Jun 2, 2025
DanRibbens
previously approved these changes
Jun 2, 2025
DanRibbens
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
I had a few minor questions.
DanRibbens
approved these changes
Jun 3, 2025
This was referenced Jun 3, 2025
Contributor
|
🚀 This is included in version v3.41.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: An intentional effort is being made during migration to not modify runtime behavior. This implies that there will be several assertions, non-null assertions, and @ts-expect-error. This philosophy applies only to migrating old code to TypeScript strict, not to writing new code. For a more detailed justification for this reasoning, #11840 (comment).
In this PR, instead of following the approach of migrating a subset of files, I'm migrating all files by disabling a specific rule. In this case,
strictNullChecks.strictNullChecksis a good rule to start the migration with because it's easy to silence with non-null assertions or optional chainings. Additionally, almost all ts strict errors are due to this rule.This PR improves 200+ files, leaving only 68 remaining to migrate to strict mode in the payload package.