ci: restore post-release workflow on 3.x#16748
Merged
Merged
Conversation
GitHub fires release-event workflows from the release's target_commitish branch, so 3.x releases (v3.84.1, v3.85.0) never triggered post-release because the workflow and action only existed on main.
Contributor
|
🚀 This is included in version v3.85.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Restores release notifications (PR/issue comments, website dispatch, Discord announcement) for Payload v3.x releases.
Key Changes
Port
post-releaseworkflow andrelease-commenteraction to3.x.github/workflows/post-release.ymland.github/actions/release-commenter/frommain.releaseevent workflows from the release'starget_commitishbranch, not the repo default. Since v3.84.1, releases settarget_commitish: 3.x, where neither file existed, so no workflow runs were queued.Differences vs. the version previously on
3.x(removed in ci: adjust 3.x branch references #16358)release-commenteraction: identical.post-release.yml: adds thedispatch-to-websitejob (sendsrepository_dispatchtopayloadcms/website) and pins the Discord action to a SHA. Reviewers should confirmdispatch-to-websiteis desired for 3.x releases; if the website only expects events frommain/v4, that job should be dropped before merging.Design Decisions
Chose to reinstate original workflow.
Drift risk: future edits to
post-release.ymlonmainmust be mirrored to3.x.Overall Flow
sequenceDiagram participant Releaser as tools/releaser participant GH as GitHub participant WF as post-release.yml (3.x) participant Site as payloadcms/website participant Discord Releaser->>GH: Publish release (target_commitish=3.x) GH->>WF: Trigger release:published from 3.x branch WF->>GH: Comment on linked PRs/issues (release-commenter) WF->>Site: repository_dispatch payload-release-event WF->>Discord: Post to releases + general channels