fix(richtext-lexical): internal links export as [text](undefined) in markdown transformer#16302
Merged
PatrikKozak merged 2 commits intoApr 17, 2026
Merged
Conversation
…Transformer to resolve internal links
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
…urn value and fields.url for custom links
paulpopus
approved these changes
Apr 17, 2026
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…markdown transformer (payloadcms#16302) ## Overview Payload has two types of links: custom (you type a URL) and internal (you pick a page). For internal links, Payload never stores a URL, only a reference to the page (`doc`). Whatever renders the link is responsible for resolving that reference to a URL at render time. The HTML converters handled this with an `internalDocToHref` callback. The markdown transformer didn't, so it produced `[text](undefined)` for every internal link. ## Key Changes The transformer is now a `createLinkMarkdownTransformer(args?)` factory that accepts an optional `internalDocToHref` callback. Pass it to `LinkFeature` and it gets threaded through to the transformer. Without it, internal links fall back to `[text]()` instead of `[text](undefined)`. `LinkMarkdownTransformer` remains as a static backwards-compatible export. ## Design Decisions The callback is synchronous unlike the HTML converter variant, because `doc.value` is already populated by the time markdown export runs. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1213983113414606
Contributor
|
🚀 This is included in version v3.84.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Payload has two types of links: custom (you type a URL) and internal (you pick a page). For internal links, Payload never stores a URL, only a reference to the page (
doc). Whatever renders the link is responsible for resolving that reference to a URL at render time.The HTML converters handled this with an
internalDocToHrefcallback. The markdown transformer didn't, so it produced[text](undefined)for every internal link.Key Changes
The transformer is now a
createLinkMarkdownTransformer(args?)factory that accepts an optionalinternalDocToHrefcallback. Pass it toLinkFeatureand it gets threaded through to the transformer. Without it, internal links fall back to[text]()instead of[text](undefined).LinkMarkdownTransformerremains as a static backwards-compatible export.Design Decisions
The callback is synchronous unlike the HTML converter variant, because
doc.valueis already populated by the time markdown export runs.