refactor(ui): live preview iframe loader#16004
Merged
Merged
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
jacobsfletch
commented
Mar 19, 2026
| {shouldRenderIframe && ( | ||
| <IframeLoader | ||
| id="live-preview-iframe" | ||
| onLoad={() => { |
Member
Author
There was a problem hiding this comment.
This is all the same behavior as before, just abstracted away and handled through callbacks instead.
jacobsfletch
commented
Mar 19, 2026
| */ | ||
| const livePreviewIframeID = 'live-preview-iframe' | ||
|
|
||
| export const getLivePreviewIframe = async ( |
Member
Author
There was a problem hiding this comment.
Standardizing the test locators here and strengthening its tests.
jacobsfletch
commented
Mar 19, 2026
| * 1. Only show if the load takes longer than x ms. | ||
| * 2. Once shown, force it to be visible for at least x ms to avoid flickering, even if the iframe loads before then. | ||
| */ | ||
| export const IframeLoader: React.FC<IframeLoaderProps> = ({ |
Member
Author
There was a problem hiding this comment.
Most notable changes are in this new component, which is abstract enough to use elsewhere throughout our UI over time.
AlessioGr
approved these changes
Mar 20, 2026
Contributor
|
🚀 This is included in version v3.81.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #15999.
Without optimistically loading the live preview window, the initial loading state is left unhandled when toggling into live preview for the first time. This causes users to see blank content until the iframe has loaded, without indication that something is happening.
Now, we display a loading indicator while the iframe request is in flight, that notably:
Before:
Screen.Recording.2026-03-19.at.1.23.10.PM.mp4
After:
Screen.Recording.2026-03-19.at.4.36.05.PM.mp4
Related:
ShimmerEffectcomponent now accepts arbitrary HTML attributes and supports a newtransparentprop