fix(richtext-lexical): richtext fields don't respect RTL direction for Arabic and other RTL locales#15964
Merged
Merged
Conversation
…ction css for RTL locales
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Contributor
|
Reviewing this. Meanwhile, cross-referencing this for posterity: |
GermanJablo
approved these changes
Mar 17, 2026
GermanJablo
left a comment
Contributor
There was a problem hiding this comment.
There are still some things to improve, but they're really Lexical's responsibility, so this LGTM
Contributor
|
🚀 This is included in version v3.80.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes RTL text direction not working in Lexical richtext fields when using Arabic (or other RTL) locales. Text/Textarea fields worked fine — Lexical just wasn't wired up to detect the locale direction.
Key Changes
Field.tsxnow callsuseLocale()+isFieldRTL()and passesrtldown throughLexicalProvider→LexicalEditor, settingdir="rtl"on theeditor-containerdiv when the locale is RTL.Lexical always sets
dir="auto"on paragraph nodes, which defaults to LTR for empty content regardless of the parent'sdirattribute. A CSS rule inLexicalEditor.scssfixes this by forcingdirection: rtlon[dir="auto"]elements inside an RTL container.fieldRTLandfieldLocalizedinisFieldRTL()were typed asbooleanbut callers already passboolean | undefined.packages/uihasstrict: falseso this was hidden there;packages/richtext-lexicalhasstrict: trueand surfaced it. Made both optional and exportedisFieldRTLfrom@payloadcms/uiclient exports.