Exclude closed session from get session ids method#806
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Jun 25, 2025
Merged
Exclude closed session from get session ids method#806spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Failing to exclude closed sessions causes payjoin-cli to resume a sender or receiver sessions that has already reached their final state. This update also extends the v2 e2e test to verify that no sessions are resumed after completion.
13 tasks
Collaborator
Pull Request Test Coverage Report for Build 15875716905Details
💛 - Coveralls |
spacebear21
approved these changes
Jun 25, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
ACK 0096bb3
Confirmed that the new test fails without the cli changes. Thanks for the quick turnaround on this follow-up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing to exclude closed sessions causes payjoin-cli to resume a sender or receiver sessions that has already reached their final state. This update also extends the v2 e2e test to verify that no sessions are resumed after completion.