-
Notifications
You must be signed in to change notification settings - Fork 88
Fix payjoin-cli v1 coverage #499
Copy link
Copy link
Labels
Description
One thing I noticed is that
payjoin-cliv1 is not covered, which is likely due to the missing_danger-local-httpsincontrib/coverage.shfor the v1 llvm-cov command. This can be addressed in a separate PR.
Originally posted by @spacebear21 in #497 (review)
There is another issue, which is that payjoin-cli v1 does not handle SIGINT gracefully, so it still gets forcefully shutdown in the e2e tests despite using sigint.
We should add interrupt handlers to payjoin-cli v1 to fix this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done