-
Notifications
You must be signed in to change notification settings - Fork 88
Review usage of crate::receive::Error #312
Copy link
Copy link
Closed
Description
Follow-up from #277 (review)
Server errors are meant to be returned as a response, but are being returned in places that don't always make sense, e.g.:
rust-payjoin/payjoin/src/receive/mod.rs
Line 486 in 4bc8fe3
| return Err(Error::Server("Output substitution is disabled.".into())); |
rust-payjoin/payjoin-cli/src/app/v1.rs
Line 318 in 37d255e
| .map_err(|e| Error::Server(e.into()))? |
rust-payjoin/payjoin-cli/src/app/v2.rs
Line 345 in 37d255e
| .map(|res| Psbt::from_str(&res.psbt).map_err(|e| Error::Server(e.into()))) |
It would be good to review usage of crate::receive::Error and improve error nesting generally.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Type
Projects
Status
Done