Skip to content

Review usage of crate::receive::Error #312

@spacebear21

Description

@spacebear21

Follow-up from #277 (review)

Server errors are meant to be returned as a response, but are being returned in places that don't always make sense, e.g.:

return Err(Error::Server("Output substitution is disabled.".into()));

.map_err(|e| Error::Server(e.into()))?

.map(|res| Psbt::from_str(&res.psbt).map_err(|e| Error::Server(e.into())))

It would be good to review usage of crate::receive::Error and improve error nesting generally.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions