Update fsevents to the most recent minor version to remove minimist vulnerability#993
Closed
mjziolko wants to merge 1 commit intopaulmillr:2.xfrom
Closed
Update fsevents to the most recent minor version to remove minimist vulnerability#993mjziolko wants to merge 1 commit intopaulmillr:2.xfrom
mjziolko wants to merge 1 commit intopaulmillr:2.xfrom
Conversation
Author
|
Might need to create a new target branch to get a new minor version out with this package update. webpack/watchpack relies on this semver and currently has a prototype pollution vulnerability in minimist: https://npmjs.com/advisories/1179 |
This was referenced Mar 18, 2020
Owner
|
^1.2.2 includes 1.2.11. What's the deal here? |
Owner
|
You also have invalid commit. Current chokidar 2.x branch uses fsevents |
Author
|
Yup, sorry made this PR in error. There's some issues with the semver being pinned/the mkdirp package changing hands and I've been staring at version numbers for an hour. I'll close this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://npmjs.com/advisories/1179