Skip to content

Overhaul NodeVM.#277

Merged
XmiliaH merged 3 commits intopatriksimek:masterfrom
XmiliaH:fix-276
Apr 29, 2020
Merged

Overhaul NodeVM.#277
XmiliaH merged 3 commits intopatriksimek:masterfrom
XmiliaH:fix-276

Conversation

@XmiliaH
Copy link
Copy Markdown
Collaborator

@XmiliaH XmiliaH commented Mar 25, 2020

Should fix #276.
Tried to make NodeVM more secure by catching more errors that could be leaked from host.

Should fix patriksimek#276.
Tried to make NodeVM more secure by catching more errors that could be leaked from host.
@XmiliaH XmiliaH requested a review from patriksimek March 25, 2020 21:41
@patriksimek
Copy link
Copy Markdown
Owner

Thanks @XmiliaH , this looks awesome! I'll take a deeper look asap.

@XmiliaH
Copy link
Copy Markdown
Collaborator Author

XmiliaH commented Mar 29, 2020

@patriksimek This should have been included in 3.9.1 since it fixes the breakout in the NodeVM.

@patriksimek
Copy link
Copy Markdown
Owner

@XmiliaH My goal was to publish the fix for #274 asap. I'm Sorry I didn't include this one, but I wanted to review it before I merge it and time is my biggest enemy atm :(

@patriksimek
Copy link
Copy Markdown
Owner

Can you please share your npm username? I'll grant you access to publishing.

@XmiliaH
Copy link
Copy Markdown
Collaborator Author

XmiliaH commented Mar 30, 2020

Just created the account, xmilia.

@XmiliaH XmiliaH mentioned this pull request Apr 29, 2020
@XmiliaH XmiliaH linked an issue Apr 29, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeVM Breakout NodeVM Breakout

2 participants