encode id because sonos doesn't seem to like some special characters in the id#173
Merged
pascalopitz merged 1 commit intopascalopitz:masterfrom Dec 31, 2021
Merged
Conversation
This was referenced Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for viewing a listing of On this device localMusic even when the files in the local music folder contain special characters that sonos doesn't seem to appreciate. Furthermore, it is able to play these files that contain special characters in the filename.
According to the Sonos documentation for getMetadata, the id is simply a type
string(128), but for whatever reason, at least&is not an acceptable character in the id for Sonos. By eliminating the special characters using encodeURIComponent, Sonos is able to list and play the localMusic.Resolves #172