Skip to content

Update Interner from hashbrown 0.14 to 0.15#16

Merged
pascalkuthe merged 1 commit intopascalkuthe:masterfrom
dtolnay-contrib:hashbrown
Dec 9, 2024
Merged

Update Interner from hashbrown 0.14 to 0.15#16
pascalkuthe merged 1 commit intopascalkuthe:masterfrom
dtolnay-contrib:hashbrown

Conversation

@dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Dec 9, 2024

Release notes: https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md

RawTable is no longer available in this release, in favor of recommending the HashTable API instead.

Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this upgrade, it's much appreciated!

I have additionally run this PR against the gitoxide test suite (diff and merge) and everything works like one would expect.

On top of that, I ran it against GitButler, which seemed to have received a 15% performance boost. It was an instruments run, so there may be fluctuations, but I'd call it a good sign at least.

Merging and a new release would be appreciated.

@Byron Byron requested a review from pascalkuthe December 9, 2024 06:11
Copy link
Owner

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pascalkuthe pascalkuthe merged commit 20a3e3a into pascalkuthe:master Dec 9, 2024
@Byron
Copy link
Collaborator

Byron commented Dec 9, 2024

Thank you!

I am definitely looking forward to the new release, I think it will improve performance measurably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants