displayException: Remove trailing newline#37
Merged
parsonsmatt merged 2 commits intoparsonsmatt:masterfrom Apr 11, 2025
Merged
Conversation
In parsonsmatt#36, I restructured the `AnnotatedException` `displayException` implementation so that instead of being of the form: displayException = unlines [ ... ] <> callStackMessage where callStackMessage = prettyCallStack frames It was of the form: displayException = unlines $ [ ... ] <> callStackMessage where callStackMessage = [prettyCallStack frames] I didn't realize that `unlines` adds a trailing newline, which is generally the wrong behavior for `displayException` instances. This change replaces `unlines` with `concat . intersperse "\n"` in order to regain the correct behavior.
parsonsmatt
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #36, I restructured the
AnnotatedExceptiondisplayExceptionimplementation so that instead of being of the form:It was of the form:
I didn't realize that
unlinesadds a trailing newline, which is generally the wrong behavior fordisplayExceptioninstances.This change replaces
unlineswithconcat . intersperse "\n"in order to regain the correct behavior.Before submitting your PR, check that you've:
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR: