Skip to content

flatten handles CallStacks#27

Merged
parsonsmatt merged 4 commits intomasterfrom
mattp/23-flatten-fix
Sep 8, 2023
Merged

flatten handles CallStacks#27
parsonsmatt merged 4 commits intomasterfrom
mattp/23-flatten-fix

Conversation

@parsonsmatt
Copy link
Copy Markdown
Owner

Fixes #23

This PR adjusts flatten so that it appropriately handles CallStacks. Before this, you could get into trouble like this:

flatten (AnnotatedException [callStackAnnotation] (AnnotatedException [callStackAnnotation] TestException))
    = AnnotatedException [callStackAnnotation, callStackAnnotation] TestException

After this PR, the above will evaluate to:

flatten (AnnotatedException [callStackAnnotation] (AnnotatedException [callStackAnnotation] TestException))
    = AnnotatedException [mergeCallStacks callStackAnnotation callStackAnnotation] TestException

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@parsonsmatt parsonsmatt merged commit 7087e08 into master Sep 8, 2023
@parsonsmatt parsonsmatt deleted the mattp/23-flatten-fix branch September 8, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flatten should use addCallStackToException

1 participant