Skip to content

Bug Fixes#3

Merged
marcbelmont merged 4 commits intoparkpow:masterfrom
danleyb2:run-fixes
Jun 28, 2021
Merged

Bug Fixes#3
marcbelmont merged 4 commits intoparkpow:masterfrom
danleyb2:run-fixes

Conversation

@danleyb2
Copy link
Copy Markdown
Collaborator

No description provided.

@danleyb2 danleyb2 marked this pull request as draft June 11, 2021 14:33
@danleyb2
Copy link
Copy Markdown
Collaborator Author

@marcbelmont
I am not sure we should merge this.
There are actual bugs fixed but i had to also downgrade gradle for the build to work on my AndroidStudio version.

@marcbelmont
Copy link
Copy Markdown
Contributor

marcbelmont commented Jun 11, 2021

@danleyb2 any ideas why the downgrade was needed? Did you get any error messages?

The current version is broken. Your changes will be an improvement over that.

@danleyb2
Copy link
Copy Markdown
Collaborator Author

@marcbelmont Yes. Had created this PR to share fixes to a customer.
I need to upgrade AndroidStudio higher than V3 to be able to build with the original gradle version.
Let's wait for when i am able to test with the higher version

@danleyb2 danleyb2 marked this pull request as ready for review June 28, 2021 07:16
@danleyb2
Copy link
Copy Markdown
Collaborator Author

@marcbelmont Have confirmed the APP works okay without the downgrade. Kindly review

@marcbelmont marcbelmont merged commit db2081b into parkpow:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants