Remove visibility limiter pub (crate) from Metadata#162
Merged
ascjones merged 3 commits intoparitytech:masterfrom Sep 14, 2020
enfipy:patch-1
Merged
Remove visibility limiter pub (crate) from Metadata#162ascjones merged 3 commits intoparitytech:masterfrom enfipy:patch-1
pub (crate) from Metadata#162ascjones merged 3 commits intoparitytech:masterfrom
enfipy:patch-1
Conversation
|
@enfipy, Your signature has been received. |
ascjones
approved these changes
Sep 14, 2020
Contributor
ascjones
left a comment
There was a problem hiding this comment.
LGTM.
Please run cargo +nightly fmt to satisfy the CI before I merge
Contributor
|
Fails to build now because of missing docs on public methods |
Contributor
Author
|
@ascjones Some odd error in tests, how can I fix it? |
Contributor
The tests passed, just that weird error on the end happens occasionally. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced that I could not use Metadata's main functions outside of the crate and don't see any reason why these functions should be invisible to outside.