This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
Forked at: f8c83bd Parent branch: origin/master
bkchr
reviewed
Aug 20, 2020
client/cli/src/runner.rs
Outdated
|
|
||
| task_manager.terminate(); | ||
| drop(tokio_runtime); | ||
| task_manager.clean_shutdown(); |
Member
There was a problem hiding this comment.
What is the difference? And why isn't clean_shutdown being called in Drop?
Contributor
Author
There was a problem hiding this comment.
No, clean_shutdown is async.... wait, I forgot the .await!!! 😓
cecton
commented
Aug 20, 2020
9702413 to
a017493
Compare
bkchr
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.