Related #4927: Add ss58 address format network identifier prefix for DataHighway parachain#5465
Related #4927: Add ss58 address format network identifier prefix for DataHighway parachain#5465ltfschoen wants to merge 3 commits intoparitytech:masterfrom
Conversation
|
Thanks for the heads up, but don't manage specific user-chains myself, it is up to the chain devs. f they want support, see https://github.com/polkadot-js/apps/tree/master/packages/apps-config ss58 is actually never an issue since it comes from on-chain via the spec properties, like decimals and token. |
|
The "Reserved" of |
|
Thanks for the feedback, I've pushed a commit to request indice 49, which has not been reserved |
Please take a closer look: substrate/primitives/core/src/crypto.rs Line 479 in a4ba9be |
@bkchr I've had a closer look. We asked for indice
However, now that I've looked into it further, I found that in the Polkadot Wiki here https://wiki.polkadot.network/docs/en/learn-accounts#for-the-curious-how-prefixes-work, it provides a link to https://github.com/paritytech/substrate/wiki/External-Address-Format-(SS58), which lists the following, and clearly shows that So it says Question 1: Are indices from Question 2: So based on all the above, should I modify the code of my PR to be the following instead in order for it to be approved, where Question 3: What are indices Question 4: Would it be beneficial to add the other indices that mentioned in https://github.com/paritytech/substrate/wiki/External-Address-Format-(SS58) as already being reserved into the crypto.rs file? It may make it easier if the list of available indices are all in the same place |
|
It is clear without having explicit entries for each of the reserved fields.
TL;DR Pick any unassigned number < 48 and push the change. |
|
Cheers, sorry I misinterpreted |
updates @ltfschoen ? |
UPDATE: 26 May 2020 Changed to request ss58 prefixes of 49, which has not already been reserved
What does it do?
What important points reviewers should know?
My notes: