Fix semantics of ExistenceRequirement::KeepAlive.#3796
Conversation
kianenigma
left a comment
There was a problem hiding this comment.
I am not totally convinced that the solution is to change KeepAlive's semantics. I would personally leave withdraw() to be restrictive as it was before, and make the caller (takeFees) aware of the context and call this function with more care.
Nonetheless, does solve the issue. Would be great if you bring in the test here
https://github.com/paritytech/substrate/pull/3794/files#diff-6232fdc1d60a550161c54229175b6b58R787
and close the other PR as this is an alternative.
|
Well, if you look at the documentation, this is strictly a fix: no described semantics have changed. I'm ok with the idea of adding an additional This "fix" will now allow the possibility of storage-leaks: an account may now be created (i.e. nonce is written) without an ED balance and therefore that may never be cleaned up. I would be tempted to make the UPDATE: CC @gautamdhameja @shawntabrizi and anyone else. Please ensure that this is well documented for version 2. |
No description provided.