This repository was archived by the owner on Apr 19, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
I also ran rustfmt on this and added a config file to use tabs instead of spaces. |
dvdplm
approved these changes
Aug 27, 2018
Contributor
dvdplm
left a comment
There was a problem hiding this comment.
lgtm modulo repository metadata key
snappy-sys/Cargo.toml
Outdated
| authors = ["Parity Technologies <admin@parity.io>"] | ||
| license = "MIT/Apache-2.0/BSD" | ||
| description = "Native bindings to libsnappy" | ||
| readme = "README.md" |
Contributor
There was a problem hiding this comment.
Adding a repository key is helpful.
This was referenced Aug 27, 2018
02ad8c6 to
38a20c7
Compare
All of the source code already had headers licensing under GPLv3, but the repo was missing the LICENSE file and the license was wrongly specified in Cargo.toml
29ec51b to
e7eb0f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for publishing to crates.io (a snappy crate already exists there).