Allow customizable companion refs#35
Merged
joao-paulo-parity merged 19 commits intoparitytech:masterfrom Apr 27, 2022
Merged
Conversation
a6f3114 to
794e4a4
Compare
e020a07 to
187df04
Compare
alvicsam
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This will require a PR on Substrate after it's merged
The intended usage pattern on CI is provided by
--companion-overridesfrom$COMPANION_OVERRIDES.Use-case of correlating an existing matching branch: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1526107#L98
release-v0.9.20was used for the Polkadot companion because I am targettingpolkadot-v0.9.20in the PR (notice the version correlation). This required$COMPANION_OVERRIDES.Use-case of correlated an existing branch by guess: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1526106#L124
polkadot-v0.9.19was used for the Cumulus companion because the script tried to usepolkadot-v0.9.20(correlated frompolkadot-v0.9.20which I am targetting in the PR), which doesn't exist, thus it guessed the first. This required$COMPANION_OVERRIDES.Use-case of overriding the companion branch: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1526105#L98
cumulus companion branch: polkadot-v0.9.18in the pull request's descriptionclose #32