Skip to content

Enforce parity-scale-codec-derive version with =x.y.z.#696

Merged
gui1117 merged 3 commits intomasterfrom
gui-maybe-enforce-version
Feb 4, 2025
Merged

Enforce parity-scale-codec-derive version with =x.y.z.#696
gui1117 merged 3 commits intomasterfrom
gui-maybe-enforce-version

Conversation

@gui1117
Copy link
Copy Markdown
Contributor

@gui1117 gui1117 commented Jan 31, 2025

image

Rust doc suggest this approach can be ok: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#version-metadata

I am not sure myself, but I think it can be better.

@gui1117
Copy link
Copy Markdown
Contributor Author

gui1117 commented Jan 31, 2025

The CI job: cargo publish -p parity-scale-codec --dry-run fails but it is expected. We would need to publish parity-scale-codec-derive before publishing parity-scale-codec.

serban300
serban300 previously approved these changes Feb 4, 2025
@serban300 serban300 self-requested a review February 4, 2025 07:18
@serban300 serban300 dismissed their stale review February 4, 2025 07:19

left 1 comment

@gui1117 gui1117 requested a review from a team as a code owner February 4, 2025 08:12
@gui1117
Copy link
Copy Markdown
Contributor Author

gui1117 commented Feb 4, 2025

Then I changed the CI a bit.

  • do publish dry-run for parity-scale-codec-derive instead of parity-scale-codec
  • publish job: publish both crates in the correct order.

@gui1117 gui1117 merged commit 02dba0f into master Feb 4, 2025
@gui1117 gui1117 deleted the gui-maybe-enforce-version branch February 4, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants