Allow different reprs to still work#687
Merged
Conversation
Contributor
|
@jsdw please, can you also update the version to 3.7.2 ? |
Contributor
Author
|
Done! I have to head out now but if it's failing tests or anything I'll sort it out later or in the morning! |
bkchr
approved these changes
Jan 27, 2025
pkhry
reviewed
Jan 28, 2025
pkhry
approved these changes
Jan 28, 2025
gui1117
reviewed
Jan 31, 2025
| } else { | ||
| Err(syn::Error::new( | ||
| discriminant.span(), | ||
| "Discriminant must be an integer literal in the range 0..255", |
Contributor
There was a problem hiding this comment.
Forcing this to be an integer is a breaking change.
Potential fix: #695
gui1117
reviewed
Jan 31, 2025
| if index.is_none() { | ||
| if let Some((_, Expr::Lit(ExprLit { lit: Lit::Int(disc_lit), .. }))) = &v.discriminant { | ||
| index = disc_lit.base10_parse::<usize>().ok() | ||
| } |
Contributor
There was a problem hiding this comment.
This is ignoring the discriminant when defined with an expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't output suffixes when generating the index array in the const fun, to avoid the suffix types from conflicting with the declared type of the index array (usize) which leads to compile errors when indexes are from discriminants and are not usizes.
Should fix #686