Fix MaxEncodedLen derive macro for enum with skipped variant#622
Merged
ggwpez merged 5 commits intoparitytech:masterfrom Aug 23, 2024
Merged
Conversation
davxy
approved these changes
Aug 18, 2024
shawntabrizi
approved these changes
Aug 18, 2024
This reverts commit 40f632b90663e49ef79b1d19d054c672d46b22d5.
Contributor
Author
|
CI fails because I am external maybe? or CI is down? |
ggwpez
approved these changes
Aug 22, 2024
Member
|
@gui1117 i started the CI now. Looks like the format is not happy and the clippy because of unconstructed variants 🙃 |
Contributor
Author
Thanks, it should be fixed hopefully |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now
MaxEncodedLendo not differentiate betwen skipped variants and normal variants on enum.Now skipped variant are correctly skipped.
(also thinking again, it is not so much consistent to have skipped variant being not decodable and skipped fields being decoded to default value. Maybe it should be 2 different names)