Merged
Conversation
(it is the less impacting approach).
`get_malloc_size_src.sh`. Add missing impls.rs with ethereum types related implementation.
Fix a no_std deps issue.
Documentation enhancements. Explicits imports.
Co-Authored-By: cheme <emericchevalier.pro@gmail.com>
Add malloc_size_of impl.
Contributor
|
I would personally go for a breaking change approach (I guess |
Collaborator
Author
|
I did not see uint 0.6.0 published on crates.io, so it is probably fine not to increment. For patricia_trie the dependency is a test dependency, so I think there is no need. |
Merged
can activate prefix with feature).
ordian
reviewed
Jan 23, 2019
ordian
approved these changes
Jan 25, 2019
Collaborator
Author
|
Since memory-db and patriciatrie has moved to |
This was referenced Feb 27, 2019
Contributor
|
Just discovered https://github.com/Aeledfyr/deepsize (similar to estimate-heapsize), although it seems to be unmaintained. |
dvdplm
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way macos is handled by malloc_size of (in #89 the test was not activated and I did not see the failure for macos).
When no allocator is set macos will use estimate-heapsize (the tests are pretty bad looking but I did not find a better alternative).
Note that I would rather call the system allocator but did not know if the equivalent of 'malloc_size' is exposed anywhere.
If jemalloc is set macos will use jemalloc sizeof (this is the target for parity ethereum).
This PR also allows usage of
MallocSizeOftrait onMemoryDBand mark oldmem_usedmethod as deprecated.The related future changes for parity-ethereum would be : openethereum/parity-ethereum@master...cheme:rem_heapsize .