feat(keepalive): expose tcp keep-alive options#1583
Merged
jsdw merged 10 commits intoparitytech:masterfrom Aug 11, 2025
Merged
Conversation
Contributor
Author
|
Hi @jsdw, can you let me know if you need any changes to this ? |
jsdw
reviewed
Jul 3, 2025
Collaborator
Sorry, have been busy with a bunch of other things atm!
I would do this in this PR rather than a separate one because I'd rather that things were in a consistent state, and it would be easy to forget the follow-up and leave things in a slightly weird place :) |
Collaborator
|
I had a look and doesn't look like it makes sense currently to add those options elsewhere, so will get this merged as is! |
jsdw
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes TCP keepalive options to the base client.
related to this issue.
opening a pr to expose the following options upstream from the internal http-connector.