Conversation
jsdw
approved these changes
Feb 25, 2025
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the project configuration for the Rust 2024 edition while introducing new lint settings and adjusting several import orders and formatting details across multiple files.
- Update Cargo.toml files to use Rust 2024 edition, a new resolver version, and updated rust-version.
- Add unified lint configuration sections and adjust CI workflow to install the stable Rust toolchain.
- Reorder and reformat imports and error messages in several modules for improved consistency.
Reviewed Changes
| File | Description |
|---|---|
| Cargo.toml | Update resolver version and Rust edition/version settings |
| .github/workflows/ci.yml | Add step to install the Rust stable toolchain |
| client/http-client/Cargo.toml | Add lint configuration |
| client/transport/Cargo.toml | Add lint configuration |
| client/wasm-client/Cargo.toml | Add lint configuration |
| core/Cargo.toml | Add lint configuration |
| client/ws-client/Cargo.toml | Add lint configuration |
| client/http-client/src/transport.rs | Reorder import statements |
| core/src/lib.rs | Reorder public exports for clarity |
| client/transport/src/ws/mod.rs | Adjust import order and modify error message formatting |
| core/src/params.rs | Simplify and reformat if-let blocks for conciseness |
| client/ws-client/src/lib.rs | Reorder imports and adjust reexports |
| client/http-client/src/tests.rs | Reorder imports |
| client/wasm-client/src/lib.rs | Remove overly aggressive warning attributes (comments unchanged) |
| benches/bench.rs | Reorder imports |
| client/transport/src/web.rs | Reorder websocket import statements |
| client/transport/src/lib.rs | Remove warning attributes reordering |
| client/http-client/src/client.rs | Adjust import order |
| client/ws-client/src/tests.rs | Reorder imports |
| client/http-client/src/lib.rs | Remove warning attributes reordering |
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
client/transport/src/ws/mod.rs:431
- Consider revising this error message to include proper punctuation and clearer instructions to improve readability and usability.
let e = format!("path_and_query: {location}; this is a bug it must contain `/` please open issue");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drop order for
if letis a bit scary but I expect the 2024 edition lints to detect such things.