refactor(server): make ProxyGetRequestLayer http middleware support multiple path-method pairs#1492
Merged
niklasad1 merged 4 commits intoparitytech:masterfrom Nov 25, 2024
Conversation
ProxyGetRequest http middleware support multiple path-method pairsProxyGetRequestLayer http middleware support multiple path-method pairs
… multiple path-method pairs **BREAKING CHNAGES**: - change `ProxyGetRequestLayer::new` method to support multiple path-method pairs - remove `ProxyGetRequest::new` method, which is useless
c62a917 to
e5ada32
Compare
Contributor
Author
|
@niklasad1 @jsdw PTAL |
niklasad1
reviewed
Nov 15, 2024
|
|
||
| [dependencies] | ||
| futures-util = { version = "0.3.14", default-features = false, features = ["io", "async-await-macro"] } | ||
| jsonrpsee-types = { workspace = true } |
Contributor
There was a problem hiding this comment.
did you sort the dependencies here or why is this changed?
Contributor
Author
There was a problem hiding this comment.
Yes, this is automatically done by my vscode extension if I change the Cargo.toml.
Contributor
There was a problem hiding this comment.
dq: that sounds useful, what extension are you using?
Contributor
Author
There was a problem hiding this comment.
niklasad1
approved these changes
Nov 15, 2024
Contributor
niklasad1
left a comment
There was a problem hiding this comment.
Looks good
I guess it may be useful for users that want to expose several endpoints.
lexnv
reviewed
Nov 15, 2024
lexnv
reviewed
Nov 15, 2024
lexnv
approved these changes
Nov 15, 2024
Contributor
lexnv
left a comment
There was a problem hiding this comment.
LGTM! Just some minor notes on deduplication of paths for better user errors
Thanks for contributing 🙏
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHNAGES:
ProxyGetRequestLayer::newmethod to support multiple path-method pairsProxyGetRequest::newmethod, which is useless