chore: change transport::http::response::method_not_allowed message#1452
Merged
niklasad1 merged 2 commits intoparitytech:masterfrom Sep 20, 2024
Merged
chore: change transport::http::response::method_not_allowed message#1452niklasad1 merged 2 commits intoparitytech:masterfrom
niklasad1 merged 2 commits intoparitytech:masterfrom
Conversation
niklasad1
approved these changes
Sep 19, 2024
jsdw
approved these changes
Sep 19, 2024
Collaborator
|
I thougght options might be in the error for CORS but that's just middleware now anyway right? |
Contributor
Yes, correct |
Contributor
|
The function is only used https://github.com/paritytech/jsonrpsee/blob/master/server/src/transport/http.rs#L84-#L109 and this changed error message is "more accurate" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1451