Alter headers#597
Closed
enfipy wants to merge 1 commit intoparitytech:masterfrom
Closed
Conversation
Contributor
|
Can't find I'm reluctant to add that, since it may have security implications ( I feel this is more of a problem of the client library you are using than the server, similarly how we don't accept malformed HTTP requests I'm not yet convinced we should accept malformed mime types. |
Author
|
You are right. So I think it's better to update tendermint instead: https://github.com/tendermint/tendermint/blob/346aa14db560c3c867a3e00b4fbd8b000dcffe30/rpc/jsonrpc/client/http_json_client.go#L219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR alters headers
ACCEPTand content type fortext/json.The ideal solution is to provide a method to change it via lib API but as a workaround - this will help https://github.com/adoriasoft/polkadot_cosmos_integration.