Make seal_ecdsa test cases differ from the ones used in the pallet#1268
Merged
Make seal_ecdsa test cases differ from the ones used in the pallet#1268
seal_ecdsa test cases differ from the ones used in the pallet#1268Conversation
athei
approved these changes
May 20, 2022
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri May 20 16:56:30 CEST 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
==========================================
+ Coverage 78.48% 78.72% +0.23%
==========================================
Files 227 228 +1
Lines 8645 8675 +30
==========================================
+ Hits 6785 6829 +44
+ Misses 1860 1846 -14
Continue to review full report at Codecov.
|
cmichi
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest testing those ones versus different public keys in pallet_contracts, in doc comments examples in ink! and finally in e2e waterfall tests. By doing this we make the tests independent and more robust.