feat(parser): Improve error recovery of parser#954
Merged
devongovett merged 8 commits intoparcel-bundler:masterfrom Apr 22, 2025
Merged
feat(parser): Improve error recovery of parser#954devongovett merged 8 commits intoparcel-bundler:masterfrom
devongovett merged 8 commits intoparcel-bundler:masterfrom
Conversation
Contributor
|
We have seen similar cases among Rspack users, this PR should help us resolve the issues 👍 |
Contributor
Author
|
@devongovett I added one more test, and it seems like it's already good! Can you take a look? This PR covers all necessary error recovery required for migration from |
devongovett
approved these changes
Apr 22, 2025
Member
devongovett
left a comment
There was a problem hiding this comment.
passing the options through everywhere is a bit annoying but overall seems ok
|
@devongovett thanks! Could we get another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to get some feedback before adding more test cases for error recovery.
Do you think this change sounds good to you?
Context
I'm trying to replace
swc_csswithlightningcssinstyled-jsx(and turbopack), but I found an edge case where some more error recovery is necessary due to the waystyled-jsxworks.