Skip to content

Call StyleSheet / StyleSheetExit / Rule.custom.* in visitors passed to composeVisitors#875

Merged
devongovett merged 2 commits intoparcel-bundler:masterfrom
sapphi-red:fix/call-stylesheet-in-visitors-passed-to-compose-visitors
Jan 9, 2025
Merged

Call StyleSheet / StyleSheetExit / Rule.custom.* in visitors passed to composeVisitors#875
devongovett merged 2 commits intoparcel-bundler:masterfrom
sapphi-red:fix/call-stylesheet-in-visitors-passed-to-compose-visitors

Conversation

@sapphi-red
Copy link
Copy Markdown
Contributor

@sapphi-red sapphi-red commented Dec 25, 2024

StyleSheet / StyleSheetExit / Rule.custom.* was not called for visitors passed to composeVisitors. This PR fixes that.

Edit: just noticed that there was issue at #789, fixes #789, fixes #600

@sapphi-red sapphi-red force-pushed the fix/call-stylesheet-in-visitors-passed-to-compose-visitors branch from fa63311 to 9fa6dc4 Compare December 25, 2024 09:42
@sapphi-red sapphi-red changed the title Call StyleSheet / StyleSheetExit in visitors passed to composeVisitors Call StyleSheet / StyleSheetExit / Rule.custom in visitors passed to composeVisitors Dec 25, 2024
@sapphi-red sapphi-red changed the title Call StyleSheet / StyleSheetExit / Rule.custom in visitors passed to composeVisitors Call StyleSheet / StyleSheetExit / Rule.custom.* in visitors passed to composeVisitors Dec 25, 2024
@devongovett devongovett merged commit fbae126 into parcel-bundler:master Jan 9, 2025
@sapphi-red sapphi-red deleted the fix/call-stylesheet-in-visitors-passed-to-compose-visitors branch January 9, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot composeVisitors with multiple Rules composeVisitors Rule custom and style not work well

2 participants