Skip to content

feat: @font-feature-values#840

Merged
devongovett merged 7 commits intoparcel-bundler:masterfrom
CGQAQ:font-feature-values
Jan 1, 2025
Merged

feat: @font-feature-values#840
devongovett merged 7 commits intoparcel-bundler:masterfrom
CGQAQ:font-feature-values

Conversation

@CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Oct 18, 2024

Closes: #837

@CGQAQ CGQAQ requested a review from devongovett November 15, 2024 08:43
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Nov 15, 2024

Just addressed all issues, PTAL

@devongovett
Copy link
Member

Thanks! I refactored this slightly to handle:

  • Using a custom type for declarations so they are fully parsed. With DeclarationBlock they'd all be parsed as unknown properties, and things like !important shouldn't be allowed.
  • Removed the font-display since it is not supported by any browser and will be removed from the spec.
  • Refactored FontFamily to separate FamilyName from generic family parsing. Generic families shouldn't be allowed here.
  • Handled merging duplicate declarations and rules.

@devongovett devongovett merged commit 4cffb66 into parcel-bundler:master Jan 1, 2025
@CGQAQ CGQAQ deleted the font-feature-values branch January 2, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support @font-feature-values

3 participants