Fix casing for camel-cased svg values#1108
Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom Jan 4, 2026
Merged
Conversation
noahbald
commented
Dec 11, 2025
|
|
||
| /// A value for the [color-interpolation](https://www.w3.org/TR/SVG2/painting.html#ColorInterpolation) property. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Parse, ToCss)] | ||
| #[css(case = lower)] |
Contributor
Author
There was a problem hiding this comment.
question: will this cause the value to output as e.g. "srgb" instead of "sRGB"? Afaik SVG values shouldn't be case-insensitive
Member
There was a problem hiding this comment.
yes it will. CSS values are case insensitive, but I'm not sure about SVG presentation attributes. I saw some specs mention that sRGB was case insensitive but I didn't test that.
Contributor
Author
There was a problem hiding this comment.
This example from MDN doesn't seem show any difference between casing
devongovett
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1106
Turns out these values weren't parsing because they didn't have the casing attribute applied