Allow @property to be nested inside at-rules#1090
Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom Jan 3, 2026
Merged
Allow @property to be nested inside at-rules#1090devongovett merged 1 commit intoparcel-bundler:masterfrom
@property to be nested inside at-rules#1090devongovett merged 1 commit intoparcel-bundler:masterfrom
Conversation
devongovett
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates things such that
@propertyno longer errors when nested inside an at-rule.Note:
@propertyis not allowed inside style rules (i.e. it silently acts as if it does nothing in the browser) so I left theallowed_in_style_rulecondition the way it was.Question:
test_with_optionsdoesn't appear to emit warnings inside style rules — I would've expected it to. Assuming this is incorrect any chance you could provide an idea of where to look? (Sinceallowed_in_style_ruleis already set up to return false I don't think it's that).Happy to tweak things / add tests if need be.
Closes #968