ui: Query selector state refactoring and batchUpdates support in URLState #6033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted visual differences in 120 of 402 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~5 hours of user flows against your PR. Last updated for commit dadc229. This comment will update as new commits are pushed. |
brancz
approved these changes
Nov 6, 2025
metalmatze
approved these changes
Nov 6, 2025
Member
metalmatze
left a comment
There was a problem hiding this comment.
Incredible work!
Very cool batching for the urlState and absolutely needed refactoring for the rest of the components. 💯 👏
Member
There was a problem hiding this comment.
Absolutely love the thorough tests! 💯
…' into query-selector-state-refactoring
… sum by is already set in the url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
useURLStatehook for all URL manipulations instead of accessing the query params directly.batchUpdatesin the URL State to push multiple params into the URL without creating any race conditions