query: ensure null bitmaps are properly sized before clearing a bit #6006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In filterRecord, we assume that we can ClearBit on any null bitmap slice, however, it is valid in arrow-go to represent that all elements are valid with a zero-length null bitmap, in which case ClearBit panics. This commit creates a valid null bitmap before clearing the bit. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
brancz
approved these changes
Oct 22, 2025
|
🔴 Meticulous spotted visual differences in 1 of 259 screens tested: view and approve differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 057a8dd. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In filterRecord, we assume that we can ClearBit on any null bitmap slice, however, it is valid in arrow-go to represent that all elements are valid with a zero-length null bitmap, in which case ClearBit panics. This commit creates a valid null bitmap before clearing the bit.