refactor: Scrape loop. #5945
Merged
refactor: Scrape loop. #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the scrape suceeded but the function was unable to parse the result 'continue' was called which made it immediately try again since the ticker is only waited upon at the end of the loop. This can cause a huge rps spike if the endpoint is always returning invalid profiling data. This moves the processing of the response code to a function instead that returns an error, and if an error is encountered it handles it and drops into the second select in the loop to prevent rapid reties.
|
✅ Meticulous spotted 0 visual differences across 503 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit f806d93. This comment will update as new commits are pushed. |
asubiotto
approved these changes
Sep 9, 2025
metalmatze
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the scrape suceeded but the function was unable to parse the result 'continue' was called which made it immediately try again since the ticker is only waited upon at the end of the loop. This can cause a huge rps spike if the endpoint is always returning invalid profiling data.
This moves the processing of the response code to a function instead that returns an error, and if an error is encountered it handles it and drops into the second select in the loop to prevent rapid reties.