Fix labels not appearing in SimpleMatchers after adding via context menu #5705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the "add to query" button from the metrics graph context menu, the first label would appear correctly in the SimpleMatchers component, but subsequent labels would only update the URL without reflecting in the UI until page reload. Fixed by: - Adding `key` prop to SimpleMatchers component to force re-render when query changes - Improving useEffect in SimpleMatchers with proper async cleanup to prevent race conditions
|
✅ Meticulous spotted visual differences in 16 of 572 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit fabd66a. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "add to query" button from the metrics graph context menu, the first label would appear correctly in the SimpleMatchers component, but subsequent labels would only update the URL without reflecting in the UI until page reload.
Fixed by:
keyprop to SimpleMatchers component to force re-render when query changes