Fix depth crash #5658
Merged
Fix depth crash #5658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted visual differences in 27 of 359 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 95bdf2c. This comment will update as new commits are pushed. |
manojVivek
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds null/undefined checks and introduces a helper function for calculating maximum depth.
Updated the
valueOffsetandselectionOffsetcalculations inIcicleNodeto include explicit checks for bothnullandundefinedvalues, ensuring safer handling of potential edge cases.Added a new helper function
getMaxDepthto encapsulate the logic for determining the maximum depth from adepthColumn, improving readability and reusability.