feat(debuginfo): implement ObjectSizer interface for UploadReader #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement objstore.ObjectSizer interface on UploadReader to support optimized multipart uploads. This allows objstore.TryToGetSize to determine the total size of the upload stream, enabling proper buffer pre-allocation and improving upload performance. The implementation tracks the running total of bytes read in the size field and returns it via ObjectSize(), resolving the warning: "could not guess file size for multipart upload; upload might be not optimized"
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
objstore.ObjectSizerinterface on UploadReader to support optimized multipart uploads. This allowsobjstore.TryToGetSizeto determine the total size of the upload stream, enabling proper buffer pre-allocation and improving upload performance.The implementation tracks the running total of bytes read in the size field and returns it via
ObjectSize(), resolving the below warning when using a S3 storage fordebuginfo.