ui: Unified Label Selector #5589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 1 of 311 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 91d453e. This comment will update as new commits are pushed. |
yomete
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes that introduces additional capabilities to the existing
SimpleMatchersto allow them to select both the profile labels and the utilization labels with a distinction in the UI to group the label names based on their type.Note: This is only an optional feature and doesn't introduce any change in behavior to Parca as the component will behave as is.