pkg/parcacol: Sum into a single series if no sum by given #5580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would sum by all labels but this doesn't scale when there are hundreds of series available. Instead, we now have `sum by()` create a single series, much like in Prometheus. This is easier to draw and less confusing to the users.
|
🤖 Meticulous evaluated 50 user flows and took 315 visual snapshots. Meticulous has not yet run on cc3456b of the main branch and so there was nothing to compare against. If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch. Last updated for commit f608093. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would sum by all labels but this doesn't scale when there are hundreds of series available. Instead, we now have
sum by()create a single series, much like in Prometheus. This is easier to draw and less confusing to the users.