area/ui: Multiple metrics graph #5572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
approved these changes
Mar 18, 2025
Member
metalmatze
left a comment
There was a problem hiding this comment.
One question. Otherwise looking great!
Comment on lines
88
to
97
| switch (name) { | ||
| case 'GPU Utilization': | ||
| return 'percent'; | ||
| case 'GPU Memory Utilization': | ||
| return 'percent'; | ||
| case 'GPU Power': | ||
| return 'watts'; | ||
| default: | ||
| return 'percent'; | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure where the name variable comes from, but it feels like it should be based on the metric name and not on the axis label. Otherwise looks good to me.
|
✅ Meticulous spotted zero visual differences across 360 screens tested: view results. Meticulous simulated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 821fb8f. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.