Skip to content

Conversation

@yomete
Copy link
Contributor

@yomete yomete commented Jul 31, 2024

This PR implements a new "Simple" mode for querying for label names and values in Parca where users will be able to use a select dropdown to choose the label name, operator and label value. The existing freeform querying remains as the "Advanced" mode.

image

To improve the UX of when there are multiple filters, only the first three are shown with the rest behind a "Show more" button.
image

Resolves #4898

@yomete yomete requested a review from a team as a code owner July 31, 2024 14:21
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 1, 2024

🤖 Meticulous spotted visual differences in 531 of 625 screens tested: view and approve differences detected.

Last updated for commit 77c31c3. This comment will update as new commits are pushed.

Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete yomete merged commit 571dd79 into main Aug 6, 2024
@yomete yomete deleted the toggle-query-browser branch August 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a "Simple" and "Advanced" toggle for the query browser (Parca design refresh)

3 participants