Skip to content

Conversation

@yomete
Copy link
Contributor

@yomete yomete commented Jul 25, 2024

Note: PR #4959 should be looked at, reviewed, and merged in before taking a look at this PR. i.e. #4959 takes precedence over this.

Follow up:
Implement new design for compare page

@yomete yomete requested a review from a team as a code owner July 25, 2024 11:51
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Jul 25, 2024

🤖 Meticulous spotted visual differences in 640 of 680 screens tested: view and approve differences detected.

Last updated for commit bd1b96d. This comment will update as new commits are pushed.

@yomete yomete changed the base branch from main to new-viz-toolbar August 15, 2024 15:08
@yomete yomete requested a review from a team as a code owner August 15, 2024 15:08
@yomete yomete changed the title area/ui: Parca design refresh (wip) area/ui: Parca design refresh Aug 15, 2024
@brancz
Copy link
Member

brancz commented Aug 19, 2024

Three small things:

  1. I believe the original design had a horizontal line after the metrics graph, I feel like this was nice to separate the two sections.
  2. The iciclegraph still has a box around it, if anything, then I think the main visualization should be the thing that uses the most pixels possible.
  3. Perhaps this can be integrated in 1, but the original design also had a button for hiding the metrics graph. I feel like it would be nice to have this.

@manojVivek
Copy link
Contributor

May not be directly from this PR, but looks like the min-w on the sum-by input got lost, making it difficult to see the values easily.

Screenshot 2024-08-19 at 2 52 04 PM

@yomete
Copy link
Contributor Author

yomete commented Aug 19, 2024

May not be directly from this PR, but looks like the min-w on the sum-by input got lost, making it difficult to see the values easily.

Screenshot 2024-08-19 at 2 52 04 PM

thanks for pointing out, will take a look at that.

@yomete
Copy link
Contributor Author

yomete commented Aug 19, 2024

Three small things:

  1. I believe the original design had a horizontal line after the metrics graph, I feel like this was nice to separate the two sections.
  2. The iciclegraph still has a box around it, if anything, then I think the main visualization should be the thing that uses the most pixels possible.
  3. Perhaps this can be integrated in 1, but the original design also had a button for hiding the metrics graph. I feel like it would be nice to have this.

these are all good points. I'll make sure to implement them

Base automatically changed from new-viz-toolbar to main August 19, 2024 12:29
yomete added 2 commits August 21, 2024 19:34
- Added a line to highlight difference between top and bottom visualizations
- Fixed width of sum by label dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants