don't perform a merge query when report type is metadata only #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted zero visual differences across 494 screens tested: view results. Expected differences? Click here. Last updated for commit d5b1813. This comment will update as new commits are pushed. |
cfdd5ca to
432383f
Compare
brancz
approved these changes
Jul 24, 2024
432383f to
d5b1813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that if the report type was of type
QueryRequest_REPORT_TYPE_PROFILE_METADATAthat we would still perform a merge query, throw away the samples, and then perform the metadata query.I believe we can just perform the metadata query and not perform the merge query.